Fix logic in PSM1 for updating modules for Mac and Linux if existing. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,10 +2,18 @@ if($IsMacOS -and !(Get-Module MacNotify -list)) { | |||
| Install-Module MacNotify | |||
| } | |||
|
|
|||
| if($IsMacOS -and (Get-Module MacNotify -list)) { | |||
| Update-Module MacNotify | |||
There was a problem hiding this comment.
Could we maybe use Find-Module to check if there's a newer version before executing the Update-Module?
There was a problem hiding this comment.
Hmmm, that's a really good idea.
There was a problem hiding this comment.
also... I'm not sure of a good xplat way to do this... but testing for an internet connection before the Find-Module would be ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I made the change to PSNotifySend users with the module already installed won't get the update, keeping their module broken.
While this won't fix things straight away for them, after they update to the new release of this, things will stay unbroken if we make changes to the modules we wrap this around.
Fixes #29