Fix Config files #72
Merged
Fix Config files #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jorgedevs PR looks good and I no longer see the config error in the StartKit. My only concern, is just generally, that some of our samples (eg. StartKit, Project Lab, Desktop and ReTerminal) build with warnings, that could be fixed without affecting functionality. If our samples are supposed show "best practices" when using our products, I think they should build, out of the box, with a clean sheet, without warnings. If they aren't supposed to show "best practices" then my point is moot. An example of the sort of fixes I'm talking about for the aforementioned templates can be seen in this PR - #73 Thoughts? |
Template Warnings fixes
Standardise locations of Apps and Harware as well and MeadowApp naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.