Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TapirLink #770

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

carllelandtaylor
Copy link
Contributor

[Plain-text summary description of the solution]

PR fixes #401

Changes

  • [bullet list include any model updates]
  • [new or edited functions]
  • [significant changes to UX]
  • [design decisions, especially if architectural patterns are new/altered]
  • [can use text, screenshots, or files]
  • [a callout of any ##TODO or ##FIXMEs found/created as part of the fix]

@naknomum
Copy link
Member

@carllelandtaylor to address your couple of questions in the code:

  1. TODO before merge: does some schema need updating as well? - no, we can leave the tapirlink-related column in the db. it will not be created for new wildbooks, and should not mess up existing legacy tables
  2. MassExposeGBIF.java - i agree, this servlet should also go away, as all it does is modify tapirlink values; good call. @TanyaStere42 do you agree? i think then this would cascade to mean also altering: appadmin/admin.jsp (to remove the button) and web.xml to remove the servlet entries.

@TanyaStere42
Copy link
Member

That seems like minimal scope creep, so I'm good with it if @carllelandtaylor is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove tapirlink
3 participants