Skip to content

Commit

Permalink
OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
Browse files Browse the repository at this point in the history
In case PcdFirmwareReleaseDateString is not set use a valid date
as fallback. But the default valid date can _NOT_ pass the Microsoft
SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
the error message:

BIOS Release Date string is unexpected length: 8. This string must be in
MM/DD/YYYY format. No other format is allowed and no additional information
may be included. See field description in the SMBIOS specification.

Base on SMBIOS spec v3.7.0:

08h     2.0+    BIOS Release Date       BYTE    STRING
String number of the BIOS release date. The date
string, if supplied, is in either mm/dd/yy or
mm/dd/yyyy format. If the year portion of the string
is two digits, the year is assumed to be 19yy.
NOTE: The mm/dd/yyyy format is required for SMBIOS
version 2.3 and later.

So, let's tweek the fallback release date again.

Fixes: a0f9628 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
Signed-off-by: "Lee, Chun-Yi" <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Laszlo Ersek <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Jordan Justen <[email protected]>
Cc: Pawel Polawski <[email protected]>
Cc: Oliver Steffen <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Ruifeng Gao <[email protected]>
Cc: "Lee, Chun-Yi" <[email protected]>
[[email protected]: Turn the CC's from the list posting to commit message
 body tags, for placating "PatchCheck.py". Also work the
 "[email protected]" email address into a format that "PatchCheck.py"
 accepts.]
  • Loading branch information
Lee, Chun-Yi authored and mergify[bot] committed Mar 5, 2024
1 parent 918288a commit 2a0d4a2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ InstallAllStructures (
DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
DateLen = StrLen (DateStr);
if (DateLen < 3) {
DateStr = L"2/2/2022";
DateStr = L"02/02/2022";
DateLen = StrLen (DateStr);
}

Expand Down

0 comments on commit 2a0d4a2

Please sign in to comment.