Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard modifiers for CAPS_LOCK and NUM_LOCK #128

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add keyboard modifiers for CAPS_LOCK and NUM_LOCK #128

wants to merge 1 commit into from

Conversation

dpino
Copy link

@dpino dpino commented Jul 6, 2023 •
edited
Loading

Several Layout tests require managing the CAPS_LOCK key. For instance:

fast/events/dblclick-event-getModifierState.html
fast/events/special-key-events-in-input-text.html
fast/forms/caps-lock-indicator-width.html

Supporting CAPS_LOCK key (as well as NUM_LOCK) will require changes in Cog, wpebackend-fdo and the WPE part of WebKit.

@dpino dpino marked this pull request as draft July 6, 2023 05:29
@dpino dpino mentioned this pull request Jul 6, 2023
Draft
@aperezdc
Copy link
Contributor

@dpino Do you have the WebKit changes already written? If yes, could you please share a link here to see that and this patch would fit together? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpino @aperezdc