Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken union of Sets #84

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Fix broken union of Sets #84

merged 1 commit into from
Aug 16, 2023

Conversation

rodolfomiranda
Copy link
Collaborator

Fixing a formula used to create a set by the union of two sets that worked in some cases, but not in others.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #84 (3f405b5) into development (bf45703) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           development      #84      +/-   ##
===============================================
- Coverage        55.98%   55.95%   -0.04%     
===============================================
  Files               33       33              
  Lines             3519     3521       +2     
  Branches           797      797              
===============================================
  Hits              1970     1970              
- Misses            1482     1484       +2     
  Partials            67       67              
Files Changed Coverage Δ
src/keri/core/eventing.ts 33.87% <0.00%> (-0.28%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AlexAndrei98 AlexAndrei98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexAndrei98 AlexAndrei98 merged commit ffe60d4 into WebOfTrust:development Aug 16, 2023
2 of 3 checks passed
@rodolfomiranda rodolfomiranda deleted the fix_sets branch October 6, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants