Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename managed identifier #283

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

iFergal
Copy link
Contributor

@iFergal iFergal commented Oct 15, 2024

I believe this was only added to signifypy following WebOfTrust/keria#218.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.57%. Comparing base (1b747f8) to head (2fb6988).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
- Coverage   83.84%   83.57%   -0.27%     
==========================================
  Files          48       48              
  Lines        4258     4220      -38     
  Branches     1057     1042      -15     
==========================================
- Hits         3570     3527      -43     
- Misses        660      663       +3     
- Partials       28       30       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/keri/app/aiding.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to finally get this in the API. I had a thought about the use of name vs prefix as the "preferred" way of doing this operation.

I'd rather see await client1.identifiers().rename(aid3.prefix, 'aid4') as the preferred method, i.e:

PUT /identifiers/prefix
{ "name": "name2" }

I find the semantics of

PUT /identifiers/name1
{ "name": "name2" }

To create a resource at /identifiers/name2 a little unintuitive.

src/keri/app/aiding.ts Outdated Show resolved Hide resolved
@lenkan lenkan self-requested a review October 16, 2024 14:12
@lenkan
Copy link
Collaborator

lenkan commented Oct 17, 2024

I will merge this one now since it seems like no one has any objections to the API.

@lenkan lenkan merged commit 36bed7b into WebOfTrust:main Oct 17, 2024
8 checks passed
@iFergal iFergal deleted the feat/renameIdentifier branch October 17, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants