-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename managed identifier #283
feat: rename managed identifier #283
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
- Coverage 83.84% 83.57% -0.27%
==========================================
Files 48 48
Lines 4258 4220 -38
Branches 1057 1042 -15
==========================================
- Hits 3570 3527 -43
- Misses 660 663 +3
- Partials 28 30 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to finally get this in the API. I had a thought about the use of name vs prefix as the "preferred" way of doing this operation.
I'd rather see await client1.identifiers().rename(aid3.prefix, 'aid4')
as the preferred method, i.e:
PUT /identifiers/prefix
{ "name": "name2" }
I find the semantics of
PUT /identifiers/name1
{ "name": "name2" }
To create a resource at /identifiers/name2
a little unintuitive.
I will merge this one now since it seems like no one has any objections to the API. |
I believe this was only added to signifypy following WebOfTrust/keria#218.