Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix credentialing field ordering and related singlesig-vlei-issuance test #254

Merged
merged 23 commits into from
May 8, 2024

Conversation

2byrds
Copy link
Contributor

@2byrds 2byrds commented Apr 29, 2024

  1. Fixes ordering of u field.
  2. Modifies signed fetch to give the caller control over Request related args.
  3. Improves reliability of singlesig-vlei-issuer test

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.82%. Comparing base (fddaff2) to head (4c728f1).
Report is 1 commits behind head on main.

❗ Current head 4c728f1 differs from pull request most recent head fc6d59b. Consider uploading reports for the commit fc6d59b to get more accurate results

Files Patch % Lines
src/keri/app/clienting.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   82.76%   82.82%   +0.06%     
==========================================
  Files          46       46              
  Lines        4218     4210       -8     
  Branches     1029     1049      +20     
==========================================
- Hits         3491     3487       -4     
+ Misses        722      694      -28     
- Partials        5       29      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/keri/app/clienting.ts Outdated Show resolved Hide resolved
src/keri/app/clienting.ts Outdated Show resolved Hide resolved
src/keri/app/credentialing.ts Outdated Show resolved Hide resolved
examples/integration-scripts/vlei-verification.test.ts Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@2byrds 2byrds marked this pull request as draft April 30, 2024 22:06
@2byrds 2byrds marked this pull request as ready for review May 1, 2024 15:25
Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Much easier to review now. I don't understand the changes with the retries? Does the retry function not do this for you?

Also, if not too much effort, can the changes to signedFetch be separated to it's own PR to make it easier to review the history? I feel these are two unrelated changes.

2byrds added 9 commits May 8, 2024 05:28
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
@2byrds 2byrds changed the title fixes during testing signify-ts integration test ECR creds against keri verification service fix credentialing field ordering and related singlesig-vlei-issuance test May 8, 2024
Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenkan lenkan merged commit 2b6a2fd into WebOfTrust:main May 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants