Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note the state of the proposal #50

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Note the state of the proposal #50

merged 2 commits into from
Jul 12, 2024

Conversation

abrown
Copy link
Collaborator

@abrown abrown commented Jul 3, 2024

The CG has reached agreement that the future of threads in WebAssembly goes through the shared-everything-threads proposal. This change tries to communicate the "legacy" nature of wasi-threads: still valuable in some cases but planned for eventual deprecation.

The CG has reached agreement that the future of threads in WebAssembly
goes through the shared-everything-threads proposal. This change tries
to communicate the "legacy" nature of wasi-threads: still valuable in
some cases but planned for eventual deprecation.
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -3,6 +3,16 @@
A proposed [WebAssembly System Interface](https://github.com/WebAssembly/WASI)
API to add native thread support.

> __NOTE__: this proposal is considered a legacy proposal, retained for engines
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we perhaps mention there are runtimes already implementing this proposal (WAMR specifically) and teams that rely on it, so it will be around for quite some time?

I understand we want to encourage people to wait and use the new proposal, but if there are people like us who got stuck with this proposal and can't migrate, they can open a ticket in this repo to contact us for any relevant topic - I'll be actively monitor this repo and reply to those tickets.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, those are good points. I'll try to add something about that. Can you think of anyone else I should put on the "contact these people" list?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put my name on the list for now. Not sure if anybody from WAMR and the community around it (maybe @yamt , @wenyongh) would like to be included.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please feel free to include me.
however, i'm not sure if such a list is necessary.
a list of links to github issues of relevant repos, including this repo, should be enough.
it probably even works better than a person-level contact list.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please feel free to include me too if the list is added.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, see 21f7eb2; @yamt, I ended up doing both — your "add an issue" suggestion plus "a list of people" to tag.

README.md Show resolved Hide resolved
Copy link
Collaborator

@loganek loganek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abrown abrown merged commit af51ac8 into WebAssembly:main Jul 12, 2024
1 check passed
@abrown abrown deleted the set branch July 12, 2024 04:17
abrown added a commit to abrown/wasi-threads that referenced this pull request Jul 12, 2024
As suggested by @yamt in a [comment], it may be better to avoid
highlighting WAMR exclusively in the top-level "warning." Instead, this
updates the implementation status for known engines.

[comment]: WebAssembly#50 (comment)
abrown added a commit that referenced this pull request Jul 17, 2024
As suggested by @yamt in a [comment], it may be better to avoid
highlighting WAMR exclusively in the top-level "warning." Instead, this
updates the implementation status for known engines.

[comment]: #50 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants