Add more details about running tests #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganek
commented
Jan 20, 2023
test/README.md
Outdated
| ```bash | ||
| git clone -b prod/testsuite-all https://github.com/WebAssembly/wasi-testsuite | ||
| cd wasi-testsuite/ | ||
| TEST_RUNTIME_EXE="wasmtime <TBD flags>" python3 test-runner/wasi_test_runner.py \ |
There was a problem hiding this comment.
Please note TEST_RUNTIME_EXEC is a feature in PR right now: WebAssembly/wasi-testsuite#46
loganek
commented
Jan 20, 2023
test/README.md
Outdated
| ```bash | ||
| git clone -b prod/testsuite-all https://github.com/WebAssembly/wasi-testsuite | ||
| cd wasi-testsuite/ | ||
| TEST_RUNTIME_EXE="wasmtime <TBD flags>" python3 test-runner/wasi_test_runner.py \ |
There was a problem hiding this comment.
@abrown would you be able to help with wasmtime flags to enable threads?
There was a problem hiding this comment.
I think this needs --wasm-features=threads --wasi-modules=experimental-wasi-threads. Now, it might be good to note (or not, it's up to you) that these are not yet merged into the main branch (waiting on bytecodealliance/wasmtime#5484 to merge...).
|
And I'm making a note to run these when I have a chance. |
loganek
force-pushed
the
loganek/update-tests
branch
from
5349d71
to
28c1724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.