Clarify HAL usage #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. Thx for clarifying |
ricochet
approved these changes
Apr 18, 2024
sunfishcode
reviewed
Apr 18, 2024
| @@ -30,6 +34,8 @@ The primary goal is to provide an interface that WASI programs can use to read a | |||
|
|
|||
| Although I2C is in some aspects not that different from SPI, the purpose of this proposal is to solely focus on I2C. | |||
|
|
|||
| Currently, behaviour that is not specified by this API is seen as undefined and, unless there's sufficient interest, is regarded as out-of-scope. | |||
There was a problem hiding this comment.
Could you expand on what kind of behavior this is meant to cover?
My thought is, we don't need to specify the full semantics of the I2C protocol in WASI; we just need to specify how the WASI APIs map to I2C operations. With that understanding, it seems like a lot of places where there's ambiguity in terms of what the exact behavior is can be left to the I2C standards to figure out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the wording around
embedded-halcan be interpreted as such that this library is necessary for an implementation. This is not the case, and thus this phrase is rewritten.In the non-goals, a paragraph is added around behaviour not specified in this proposal. The intent behind this paragraph is to only populate the specification with behaviour with clear interest from the industry.