Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connect Blockchain]Improve Mobile EVM docs #948

Merged
merged 3 commits into from
Oct 17, 2024
Merged

[Connect Blockchain]Improve Mobile EVM docs #948

merged 3 commits into from
Oct 17, 2024

Conversation

AyushBherwani1998
Copy link
Member

@AyushBherwani1998 AyushBherwani1998 commented Oct 16, 2024 •
edited
Loading

Motivation and Context

Jira Link: https://toruslabs.atlassian.net/browse/DEVREL-1045?atlOrigin=eyJpIjoiNzFkMmYzNjg0Yjk0NDY5N2FmNmJhNDI0NDVjNmM4NzkiLCJwIjoiaiJ9

Description

Improve EVM Flutter, Android & iOS docs, make code copy pastable

How has this been tested?

This has been tested locally

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@vercel Vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 2:54am

@AyushBherwani1998 AyushBherwani1998 changed the title [Connect Blockchain]Improve Flutter EVM docs [Connect Blockchain]Improve Flutter & iOS EVM docs Oct 16, 2024
@AyushBherwani1998 AyushBherwani1998 changed the title [Connect Blockchain]Improve Flutter & iOS EVM docs [Connect Blockchain]Improve Mobile EVM docs Oct 17, 2024
shahbaz17
shahbaz17 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@shahbaz17 shahbaz17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AyushBherwani1998 AyushBherwani1998 merged commit b4469ca into master Oct 17, 2024
5 checks passed
@AyushBherwani1998 AyushBherwani1998 deleted the connect-blockchain-pnp-mobile branch October 17, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahbaz17 shahbaz17 shahbaz17 approved these changes

Assignees
No one assigned
Labels
check-links
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyushBherwani1998 @shahbaz17