Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mobile SFA Guides #926

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Update Mobile SFA Guides #926

merged 3 commits into from
Sep 30, 2024

Conversation

AyushBherwani1998
Copy link
Member

Motivation and Context

Jira Link: https://toruslabs.atlassian.net/browse/DEVREL-1004?atlOrigin=eyJpIjoiNDI4MWY4YzIzODIyNDMxOTgxYWYyYmI1ZmIyNGM0MzgiLCJwIjoiaiJ9

Description

Update SFA Mobile guides and make it modular to improve maintenance of the guides

How has this been tested?

This has been tested locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vercel Vercel
Copy link

vercel bot commented Sep 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 6:07am

yashovardhan
yashovardhan approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@yashovardhan yashovardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AyushBherwani1998 AyushBherwani1998 merged commit 585bca9 into master Sep 30, 2024
3 checks passed
@AyushBherwani1998 AyushBherwani1998 deleted the mobile-guide-updates branch September 30, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashovardhan yashovardhan yashovardhan approved these changes

Assignees
No one assigned
Labels
check-links
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyushBherwani1998 @yashovardhan