Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-layout): 调整 layout: aside 的 logo 布局 #230

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

1zumii
Copy link
Collaborator

@1zumii 1zumii commented Feb 2, 2024

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

@1zumii 1zumii requested review from wanchun and winixt February 2, 2024 10:33
font-weight: 600;
font-size: 18px;
line-height: 32px;
text-align: center;
}
}
.layout-menu {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码的目的是对某个导航栏组件进行样式调整。以下是关于代码的一些建议和可能的问题:

  1. 删除了height: 32px;,这可能会导致 logo 图片高度缩小,需要确认此更改是否符合设计需求。

  2. 添加了flex-direction: column;属性,将内部元素从水平排列改为垂直排列。这可能是为了使 logo 图片和名称在垂直方向上对齐,请确保这符合设计预期。

  3. 添加了object-fit: contain;属性来控制 logo 图片的适应性。这将确保图片按比例缩放并完全容纳在指定的高度范围内,可以避免图像失真或溢出的问题。

  4. 修改了.logo-name类的margin属性,将其修改为margin: 12px 0 0 0;。这将在 Logo 名称顶部添加空白间距,请确保这个修改与设计一致。

  5. 添加了.logo-name类的text-align: center;属性,用于将文本内容居中对齐。请确保这个更改符合你的设计需求。

除此之外,其他部分的代码没有变化。代码审查可以进一步检查是否还有其他问题,例如命名规范、清晰度和可维护性等方面。

@winixt winixt merged commit e8aad1f into master Feb 22, 2024
2 checks passed
@winixt winixt deleted the feat-layout branch February 22, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants