Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO Shiny Hunting Simulator 2020 #181

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Mygod
Copy link
Contributor

@Mygod Mygod commented Sep 13, 2020

I made an abomination.

TODOs:

  • Release more shinies than Magikarp? We need to be better than Niantic.
  • Allow to turn off shinies on the map in settings and turn it off by default. (should we create a setting for each in wild/quest/raid?)
  • Fancy animations for shinies.
  • Indicators for shinies?
  • Loud shiny noises?
  • Is this cyrb53 a statistically good hash function?
  • Support invasion grunt shinies?

Credits: Inspired by this shiny luck simulator.

Currently only Magikarp have their shinies released. Just like Pokemon GO.
@Mygod Mygod marked this pull request as draft September 13, 2020 03:32
@clburlison
Copy link
Contributor

For the love of all things holy please don't merge this without an admin level kill switch. Default to off isn't good enough. If users turn this on I 100% guarantee I will receive pings from users asking why it wasn't shiny in Pogo after the map alerted on a shiny.

@Mygod
Copy link
Contributor Author

Mygod commented Sep 13, 2020

@clburlison Well you can simply remove shinyRates, which will shiny lock all pokemon. 😉

@Mygod Mygod changed the title Add minigame for finding shinies on map GO Shiny Hunting Simulator 2020 Sep 13, 2020
@versx versx added the enhancement New feature or request label Sep 28, 2020
@versx
Copy link
Collaborator

versx commented Apr 29, 2021

I still think this would be a cool thing to implement. Maybe we could have a warning when enabling it to let the user know that the shiny on the map would not necessarily mean it's shiny in-game and only for visual aesthetics/fun fidget spinner type of game.

I know I had fun trying to find a shiny by clicking everything lol.

@Mygod
Copy link
Contributor Author

Mygod commented Apr 29, 2021

Truth is there is no hope for GOSHS 2020 now. You can only cross your fingers for GOSHS 2021. 🙃

Feel free to implement it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants