Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating local_env.py #76

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Updating local_env.py #76

merged 6 commits into from
Nov 21, 2023

Conversation

faizan12123
Copy link
Contributor

@faizan12123 faizan12123 commented Nov 15, 2023

Description

The local_env.py file was outdated and certain variables needed to be updated. There was also an error with generating two of the environment variables: ANALYZER_DJANGO_SECRET_KEYand ANALYZER_DB_PASSWORD. Previously, they were being generated as byte-strings which was not expected from the code base. Now they are generated using python's secrets library.

Motivation and Context

This change was required because the Artemis project does not build correctly locally due to the local_env.py file being inaccurate.

How Has This Been Tested?

This has been tested by running the command: python3 local_env.py > .envand ensuring that the .env file was generated correctly. It was also tested in a development environment to ensure no breaking changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@faizan12123 faizan12123 changed the title updating the local_env.py file to update some of the values and fix a… updating the local build process and instructions Nov 15, 2023
@faizan12123 faizan12123 changed the title updating the local build process and instructions updating the local_env.py file Nov 20, 2023
@faizan12123 faizan12123 changed the title updating the local_env.py file Updating local_env.py Nov 20, 2023
@faizan12123 faizan12123 marked this pull request as ready for review November 20, 2023 18:16
@faizan12123 faizan12123 requested a review from a team as a code owner November 20, 2023 18:16
@faizan12123 faizan12123 merged commit e880652 into main Nov 21, 2023
2 checks passed
@davakos davakos deleted the Local-Build-Inst branch December 20, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants