Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update veracode dependencies #62

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Conversation

jlegarreta
Copy link
Contributor

@jlegarreta jlegarreta commented Jul 31, 2023

Description

Updated the following components:
Debian Bullseye (11) -> Bookworm (12)
Ant 1.10.12 -> 1.10.13
Golang 1.16.3 -> 1.20.6
Gradle 7.0 -> 8.2.1
Maven 3.8.8 -> 3.9.3
Node 14.16.1 -> 18.17.0
OpenJDK 11.x -> 17.0.8
PHP 7.4.22 -> 8.2.8
Ruby 2.7.2 -> 3.1

govendor package removed. Depreciated in favor of go modules since 2019.

Pinned docker images to hashes, pinned apt packages to versions.

Motivation and Context

Several components have not been updated in a long time. This also fixes a bug that was present in the old version NPM that was causing certain scans to fail (see npm/npm#15376).

How Has This Been Tested?

Tested locally and ran a scan in a development environment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Comment on lines -81 to -90
ARG RUBYVER=2.7.2
ARG RUBYSHA=3f50b100fb52cdf315fa17f41ae2e2538bb0c45abd9a6c569fd70ac851d61b2a
SHELL ["/bin/bash", "-o", "pipefail", "-c"]

RUN mkdir -p /ruby && \
echo "$RUBYSHA /ruby/ruby.tar.bz" > /ruby_checksum.txt && \
curl https://rvm_io.global.ssl.fastly.net/binaries/debian/10/x86_64/ruby-$RUBYVER.tar.bz2 -L -o /ruby/ruby.tar.bz && \
sha256sum -c /ruby_checksum.txt && \
tar -xjvf /ruby/ruby.tar.bz -C /ruby && \
mv /ruby/ruby-$RUBYVER /ruby/ruby && \
rm /ruby/ruby.tar.bz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to install ruby with apt-get instead, because the official website does not have binaries for Debian bookworm yet.

Comment on lines +99 to +107
ARG JAVAVER=17.0.8
ARG JAVASHA=74b528a33bb2dfa02b4d74a0d66c9aff52e4f52924ce23a62d7f9eb1a6744657

RUN mkdir -p /java && \
echo "$JAVASHA java.tar.gz" >java_checksum.txt && \
JAVAMAJOR=$(echo "${JAVAVER}" | cut -d . -f 1) && \
curl "https://download.oracle.com/java/${JAVAMAJOR}/archive/jdk-${JAVAVER}_linux-x64_bin.tar.gz" -L -o java.tar.gz && \
sha256sum -c java_checksum.txt && \
tar -xzvf java.tar.gz --strip-components 1 -C /java
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to install java from Oracle as opposed to apt. There seems to be a bug in the post-installation script of the deb package which causes installation to fail.

@jlegarreta jlegarreta marked this pull request as ready for review July 31, 2023 21:30
@jlegarreta jlegarreta requested a review from pizen as a code owner July 31, 2023 21:30
Copy link
Contributor

@g-marconet g-marconet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlegarreta jlegarreta merged commit 3586f5c into main Jul 31, 2023
1 check passed
@jlegarreta jlegarreta deleted the jlegarreta/veracode-updates branch July 31, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants