Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint/detekt: Clean up type hints and lint warnings #354

Merged
merged 5 commits into from
Nov 13, 2024
Merged

eslint/detekt: Clean up type hints and lint warnings #354

merged 5 commits into from
Nov 13, 2024

Conversation

ZoogieZork
Copy link
Contributor

@ZoogieZork ZoogieZork commented Nov 13, 2024 •
edited
Loading

Description

Cleans up type hints and lint warnings found in the ESLint and Detekt plugins.

Motivation and Context

Minor cleanups collected while working on other changes.

How Has This Been Tested?

Tested in non-prod environment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ZoogieZork ZoogieZork marked this pull request as ready for review November 13, 2024 19:32
@ZoogieZork ZoogieZork requested a review from a team as a code owner November 13, 2024 19:32
g-marconet
g-marconet approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@g-marconet g-marconet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZoogieZork ZoogieZork merged commit b514273 into main Nov 13, 2024
5 checks passed
@ZoogieZork ZoogieZork deleted the zoogiezork/eslint-detekt-cleanup branch November 13, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-marconet g-marconet g-marconet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZoogieZork @g-marconet