Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-runner: Handle missing .env file and allow writable target #336

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

ZoogieZork
Copy link
Contributor

Description

  • Properly handle the case where no .env file exists. Before, this would cause the script to exit immediately.
  • Add a new run-writable subcommand to support plugins that expect the target directory to be writable.

Motivation and Context

Fixes & features from feedback.

How Has This Been Tested?

Tested locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This is to support the few plugins that expect that the target directory
is writable (e.g. to generate a lockfile).
@ZoogieZork ZoogieZork marked this pull request as ready for review October 28, 2024 19:29
@ZoogieZork ZoogieZork requested a review from a team as a code owner October 28, 2024 19:29
@ZoogieZork ZoogieZork added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit a1f6cf8 Oct 28, 2024
5 checks passed
@ZoogieZork ZoogieZork deleted the zoogiezork/plugin-runner-fixes branch October 28, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants