Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use increasing integers instead of unique strings for internal IDs #1426

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

apasel422
Copy link
Collaborator

@apasel422 apasel422 commented Sep 11, 2024

This will make it easier to address #1405, but is beneficial in itself because it indicates the scope of the uniqueness that was previously implicit for strings.


Preview | Diff

This will make it easier to address WICG#1405, but is beneficial in itself
because it indicates the scope of the uniqueness that was previously
implicit for strings.
@apasel422 apasel422 marked this pull request as ready for review September 11, 2024 15:00
Copy link
Collaborator

@johnivdel johnivdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apasel422 apasel422 merged commit 98e9259 into WICG:main Oct 11, 2024
2 checks passed
@apasel422 apasel422 deleted the integer-internal-id branch October 11, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants