add test for ecto builder with unicode value #2

VoiSmart · Nov 23, 2022 · 31bfb54 · 31bfb54
1 parent 3451514
commit 31bfb54
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/lib/query_builders/sql_query_builder.ex b/lib/query_builders/sql_query_builder.ex
@@ -153,8 +153,6 @@ defmodule FIQLEx.QueryBuilders.SQLQueryBuilder do
 
  @impl true
  def build(ast, {query, opts}) do
- query = :binary.bin_to_list(query) |> to_string
-
  select =
  case Keyword.get(opts, :select, :all) do
  :all ->

diff --git a/test/ecto_query_builder_test.exs b/test/ecto_query_builder_test.exs
@@ -24,6 +24,23 @@ defmodule EctoQueryBuilderTest do
  assert inspect(expected) == inspect(result)
  end
 
+ test "single fiql filter with an unicode value" do
+ {:ok, result} =
+ FIQLEx.build_query(FIQLEx.parse!("firstname==さよなら"), EctoQueryBuilder,
+ schema: UserSchema,
+ select: :from_selectors
+ )
+
+ expected =
+ from(u0 in FIQLEx.Test.Support.User,
+ where: u0.firstname == ^"'さよなら'",
+ order_by: [],
+ select: [:firstname]
+ )
+
+ assert inspect(expected) == inspect(result)
+ end
+
  test "single fiql filter with select all fields" do
  {:ok, result} =
  FIQLEx.build_query(FIQLEx.parse!("firstname==John"), EctoQueryBuilder,