Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feature(protein-prospector): Add new MSstatsPTM converter for protein prospector #100

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

tonywu1999
Copy link
Contributor

@tonywu1999 tonywu1999 commented Sep 16, 2024

Motivation and Context

Our stakeholders are asking for a converter from Protein Prospector to MSstatsPTM. See this issue

Changes

  • Create converter from Protein Prospector to MSstatsPTM
  • Build succeeds locally

Testing

  • New unit tests pass

Todo

  • MSstatsPTMSiteLocator seems to have a bug with doubly modified peptides of different modification types. I will fix this in a separate PR as this is also related to other converters.
  • Each converter performs their own adhoc operations which are difficult to interpret the reasoning for. I'll look into refactoring the converters by creating helper functions in a separate PR.
  • There seems to be information on the exact location of the modification in the "Protein Mods" column, but the MSstatsPTMSiteLocator function doesn't seem to be extensible to parse this column out. I may refactor this code to allow the "Protein Mods" column to be used instead of parsing the modified peptide column in a revision to this PR.

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules - depends on TMT converter so dry run build fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant