Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add business funnel demo and related docs #2983

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

LofiSu
Copy link

@LofiSu LofiSu commented Jul 22, 2024

[中文版模板 / Chinese template]

🤔 This is a Demo add business funnel demo and related docs

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • [ √] Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

🔗 Related PR link

#2657

🐞 Bugserver case id

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@github-actions github-actions bot added the docs label Jul 22, 2024
points: (datum, ctx, params, dataView) => {
const { getPoints } = ctx;
const points = getPoints(datum);
renderCount++; // Update render count
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不太理解这个 renderCount 的作用,感觉没有很 hack;
如果是为了解决什么问题,应该有别的方案

@xiaoluoHe
Copy link
Contributor

效率非常高👍,有几个问题还再仔细看一下:

  1. 跨层文字布局还是有问题:
    • 文字没有在矩形内居中
    • 图表宽度调小一些,文字重叠问题比较严重
    • 一个矩形内的 3 行文字,建议用 1 个 richtext 就可以了,省的要写 3 个 text 图元
  2. 文字最好计算一下 maxLength,在空间不够的时候,可以自动省略;
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants