Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage test #108

Closed
wants to merge 3 commits into from
Closed

coverage test #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45de7f6
coverage test
danipv May 10, 2024
96746ba
test
danipv May 10, 2024
7983aec
test
danipv May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions Packs/VirusTotal/Integrations/VirusTotalV3/VirusTotalV3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,17 +851,10 @@ def is_preferred_vendors_pass_malicious(self, analysis_results: dict) -> bool:
item for item in preferred_vendor_scores.values() if item.get('category') == 'malicious'
]
if len(malicious_trusted_vendors) >= self.trusted_vendors_threshold:
self.logs.append(
f'{len(malicious_trusted_vendors)} trusted vendors found the hash malicious. \n'
f'The trusted vendors threshold is {self.trusted_vendors_threshold}. \n'
f'Malicious check: {(len(malicious_trusted_vendors) >= self.trusted_vendors_threshold)=}. '
)

return True
else:
self.logs.append(
f'Those preferred vendors found the hash malicious: {malicious_trusted_vendors}. '
f'They do not pass the threshold {self.trusted_vendors_threshold}. '
)

return False

def is_malicious_by_threshold(self, analysis_stats: dict, threshold: int) -> bool:
Expand Down
2 changes: 1 addition & 1 deletion Packs/VirusTotal/Integrations/VirusTotalV3/VirusTotalV3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,7 +1666,7 @@ script:
description: The analysis ID.
type: String

dockerimage: demisto/python3:3.10.13.89009
dockerimage: demisto/python3:3.10.14.92207
tests:
- VirusTotalV3-test
- VirusTotal (API v3) Detonate Test
Loading