Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decompiler option access API #418

Merged
merged 4 commits into from
Aug 18, 2024
Merged

Decompiler option access API #418

merged 4 commits into from
Aug 18, 2024

Conversation

sschr15
Copy link
Member

@sschr15 sschr15 commented Aug 18, 2024

This also moves ConsoleHelp to use the API class instead of re-parsing again.

@sschr15 sschr15 added the Type: Enhancement New feature or request label Aug 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 18, 2024 •
edited
Loading

Test Results

   18 files  ±0     18 suites  ±0   1m 3s ⏱️ ±0s
1 920 tests ±0  1 919 ✅ ±0  1 💤 ±0  0 ❌ ±0 
2 536 runs  ±0  2 534 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 032e915. ± Comparison against base commit 6930e47.

♻️ This comment has been updated with latest results.

@sschr15 sschr15 marked this pull request as ready for review August 18, 2024 21:56
@sschr15 sschr15 requested a review from jaskarth August 18, 2024 21:56
jaskarth
jaskarth requested changes Aug 18, 2024
View reviewed changes
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think getAll and getAllByPlugin need javadoc, but other than that this looks good!

@sschr15 sschr15 requested a review from jaskarth August 18, 2024 22:26
jaskarth
jaskarth approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jaskarth jaskarth merged commit 6333850 into develop/1.11.0 Aug 18, 2024
9 checks passed
@jaskarth jaskarth deleted the feature/option-lookups branch August 23, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaskarth jaskarth jaskarth approved these changes

Assignees
No one assigned
Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sschr15 @jaskarth