Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix final variable definition that is used in a for loop being moved outside the for loop #311

Merged
merged 4 commits into from
Sep 9, 2023

Conversation

coehlrich
Copy link
Contributor

Fixes a compile error in RealmsSelectWorldTemplateScreen where a variable is used in a lambda but the definition is being moved outside a for loop causing the variable to no longer be effectively final.

@codecov-commenter

This comment was marked as outdated.

Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good, but a unit test would be great to prevent regressions.

@jaskarth jaskarth added Priority: Medium Medium priority Subsystem: Variables Anything concerning variables, types, assignments, and casting bugfix Fixes a bug labels Sep 8, 2023
@jaskarth jaskarth merged commit 98f56b5 into Vineflower:develop/1.10.0 Sep 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug Priority: Medium Medium priority Subsystem: Variables Anything concerning variables, types, assignments, and casting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants