-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class, method, and constructor declarations #307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
sschr15
force-pushed
the
feature/kotlin/declarations
branch
2 times, most recently
from
September 9, 2023 06:16
e9767c2
to
53dedc5
Compare
jaskarth
added
Type: Enhancement
New feature or request
Priority: Medium
Medium priority
Subsystem: Plugins
Anything concerning the plugins system or plugin code
labels
Sep 9, 2023
sschr15
force-pushed
the
feature/kotlin/declarations
branch
from
September 14, 2023 16:01
53dedc5
to
e6fe906
Compare
…lin/declarations # Conflicts: # plugins/kotlin/src/main/java/org/vineflower/kotlin/struct/KType.java
jaskarth
approved these changes
Jan 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Thanks for the work on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: Medium
Medium priority
Subsystem: Plugins
Anything concerning the plugins system or plugin code
Type: Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely to be the last really big Kotlin PR, set up to provide the structural groundwork around all declarations.