Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class, method, and constructor declarations #307

Merged
merged 23 commits into from
Jan 21, 2024

Conversation

sschr15
Copy link
Member

@sschr15 sschr15 commented Sep 5, 2023

Likely to be the last really big Kotlin PR, set up to provide the structural groundwork around all declarations.

@sschr15 sschr15 changed the base branch from master to develop/1.10.0 September 5, 2023 21:24
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Test Results

   27 files  ±  0     27 suites  ±0   1m 33s ⏱️ -2s
2 017 tests +114  2 017 ✅ +114  0 💤 ±0  0 ❌ ±0 
3 753 runs  ±  0  3 753 ✅ ±  0  0 💤 ±0  0 ❌ ±0 

Results for commit ce4c798. ± Comparison against base commit 9dc14fc.

♻️ This comment has been updated with latest results.

@codecov-commenter

This comment was marked as outdated.

@sschr15 sschr15 force-pushed the feature/kotlin/declarations branch 2 times, most recently from e9767c2 to 53dedc5 Compare September 9, 2023 06:16
@jaskarth jaskarth added Type: Enhancement New feature or request Priority: Medium Medium priority Subsystem: Plugins Anything concerning the plugins system or plugin code labels Sep 9, 2023
@sschr15 sschr15 marked this pull request as ready for review September 14, 2023 20:26
…lin/declarations

# Conflicts:
#	plugins/kotlin/src/main/java/org/vineflower/kotlin/struct/KType.java
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Thanks for the work on this!

@jaskarth jaskarth merged commit 773cd96 into develop/1.10.0 Jan 21, 2024
11 checks passed
@jaskarth jaskarth deleted the feature/kotlin/declarations branch April 4, 2024 18:07
@sschr15 sschr15 mentioned this pull request Aug 23, 2024
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Medium priority Subsystem: Plugins Anything concerning the plugins system or plugin code Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants