Fix local variable jad name and type where the debug name conflicts #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskarth
added
Type: Enhancement
This was referenced Jul 18, 2023
This comment was marked as outdated.
This comment was marked as outdated.
jaskarth
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Ran it over the regression suite and got this result: https://gist.github.com/jaskarth/363ce347e7204eae63fc953035f8d6d4
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cases in lambdas where the debug local variable name is used instead of the jad styled local variable name along with in certain cases the type of the local variable not being correct.