Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building on ARM64 #290

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Support building on ARM64 #290

merged 2 commits into from
Jul 20, 2023

Conversation

zml2008
Copy link
Member

@zml2008 zml2008 commented Jul 16, 2023

(such as apple silicon)

The JVMs that are built for aarch64 are a bit more limited -- I've added the new gradle-recommended toolchain resolver which can find more JVMs, and introduced some logic to pick a 'next best' JVM for compiling test data when running on an ARM system. This allows a full build to run without issue hopefully!

@codecov-commenter

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Jul 16, 2023

Test Results

     27 files  ±    0       27 suites  ±0   2m 18s ⏱️ -16s
1 990 tests +114  1 989 ✔️ +114  1 💤 ±0  0 ±0 
3 672 runs  ±    0  3 669 ✔️ ±    0  3 💤 ±0  0 ±0 

Results for commit ea533fd. ± Comparison against base commit e483b5d.

♻️ This comment has been updated with latest results.

Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaskarth
Copy link
Member

Thanks for this patch!

@jaskarth jaskarth merged commit 1778698 into develop/1.10.0 Jul 20, 2023
11 checks passed
@jaskarth jaskarth deleted the fix/arm64-build branch September 4, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants