fix:[#213] Rerun first setup in normal mode until all packages have been installed #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it make more sense to let the tests be commands? things like |
|
Oh, I assumed that |
|
This does not really address my points in the comment, as there now are multiple commands without any tests, which could still cause issues when not installed properly |
Now it will use a JSON file called tests.json. The tests (and which options have to be selected for those tests) will be stored in that file. The old system did not work for a few reasons: 1. It used commands to verify that the package was installed but most package did not have binary files installed. Instead it now checks for the file being present. 2. It used to check for the commands being present during the same boot that they were installed in. Instead it now checks on the next boot. The tests run when First Setup starts and if it's the next boot the tests run to check if the files installed by the packages are present. If they are, it proceeds with the next boot. if they are not, it run the first boot again (meaning the packages are installed again)
Forgot to do that in the last commit
muhdsalm
changed the title
muhdsalm
changed the title
axtloss
reviewed
Oct 18, 2023
axtloss
reviewed
Oct 18, 2023
axtloss
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.