Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard accessibility to move crop area with arrow keys #570

Merged

Conversation

JGuardiola95
Copy link
Contributor

@JGuardiola95 JGuardiola95 commented Oct 11, 2024

This PR adds keyboard support for moving the crop area in react-easy-crop using the arrow keys, addressing issue #569.

  • Users can now move the crop area using the arrow keys.
  • The movement is based on a customizable step size (controlled via the keyboardStep prop).
📦 Published PR as canary version: 5.1.0--canary.570.646b997.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

Copy link

codesandbox-ci bot commented Oct 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ValentinH
Copy link
Owner

Thanks for this PR, it looks good to me. Could you please reference the new option on the README?

@ValentinH ValentinH added the minor Increment the minor version when merged label Oct 11, 2024
@JGuardiola95
Copy link
Contributor Author

Thanks for this PR, it looks good to me. Could you please reference the new option on the README?

Done! 👍

@ValentinH ValentinH merged commit 646b997 into ValentinH:main Oct 11, 2024
3 checks passed
@ValentinH
Copy link
Owner

Thank you for this contribution!

@ValentinH
Copy link
Owner

@allcontributors add @JGuardiola95 for code

Copy link
Contributor

@ValentinH

I've put up a pull request to add @JGuardiola95! 🎉

Copy link

🚀 PR was released in v5.1.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants