Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4901 - Create Haverfordwest (EGFE) SMR #4952

Merged
merged 10 commits into from
Sep 6, 2023

Conversation

Lucak1011
Copy link
Collaborator

@Lucak1011 Lucak1011 commented Aug 31, 2023

Fixes #4901

Summary of changes

Created SMR for EGFE
Created KMZ file for EGFE

Screenshots (if necessary)

image

< Please provide screenshots if this will facilitate a faster review of these changes - e.g. for SMR creation/updates) >

@Lucak1011
Copy link
Collaborator Author

image

Copy link
Collaborator

@PLM1995 PLM1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @Lucak1011, just a couple of minor comments.

Airports/EGFE/SMR/Geo.txt Outdated Show resolved Hide resolved
Airports/EGFE/SMR/Labels.txt Outdated Show resolved Hide resolved
Airports/EGFE/SMR/Regions.txt Outdated Show resolved Hide resolved
Airports/EGFE/SMR/Regions.txt Show resolved Hide resolved
Airports/EGFE/SMR/Regions.txt Outdated Show resolved Hide resolved
Airports/EGFE/SMR/Geo.txt Outdated Show resolved Hide resolved
@PLM1995 PLM1995 added the enhancement For new or improved features label Aug 31, 2023
@PLM1995 PLM1995 changed the title Fixes #issue-4901 - Create Haverford West (EGFE) SMR Fixes #4901 - Create Haverford West (EGFE) SMR Aug 31, 2023
@rishab-alt
Copy link
Collaborator

id suggest the things in white , change to SMRGREY and add the part here on the image , other than that its good
image

@luke11brown luke11brown changed the title Fixes #4901 - Create Haverford West (EGFE) SMR Fixes #4901 - Create Haverfordwest (EGFE) SMR Sep 1, 2023
Copy link
Contributor

@luke11brown luke11brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Airfield name is Haverfordwest, rather than Haverford West

.github/CHANGELOG.md Outdated Show resolved Hide resolved
@PLM1995
Copy link
Collaborator

PLM1995 commented Sep 6, 2023

image

@PLM1995 PLM1995 merged commit 6ae8323 into VATSIM-UK:main Sep 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For new or improved features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Haverfordwest (EGFE) SMR
6 participants