-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework showcase and add logs for other focuses #207
Draft
Fabio1988
wants to merge
3
commits into
main
Choose a base branch
from
fix-showcases
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabio1988
force-pushed
the
fix-showcases
branch
from
February 20, 2024 19:56
325ae30
to
687d307
Compare
Fabio1988
changed the title
rework showcase and add logs for second pokemon type
rework showcase and add logs for other focuses
Feb 21, 2024
Fabio1988
force-pushed
the
fix-showcases
branch
2 times, most recently
from
September 3, 2024 14:52
0ee7557
to
7d0f467
Compare
useful to refactor showcases... ponyta contained two focusses
|
Fabio1988
force-pushed
the
fix-showcases
branch
from
September 16, 2024 09:44
7d0f467
to
c41dfc8
Compare
Fabio1988
force-pushed
the
fix-showcases
branch
from
September 16, 2024 17:57
c41dfc8
to
3cb23d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow there are two pokemon types in the proto... We might need to change that at any time in the feature... So we might need to work on a new structure now, before they add new showcase stuff again.
With all those new focuses we might need to think about structure faster, as Buddy Min Level was already a showcase mid of february.