Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework showcase and add logs for other focuses #207

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Fabio1988
Copy link
Collaborator

@Fabio1988 Fabio1988 commented Jan 16, 2024

Somehow there are two pokemon types in the proto... We might need to change that at any time in the feature... So we might need to work on a new structure now, before they add new showcase stuff again.

With all those new focuses we might need to think about structure faster, as Buddy Min Level was already a showcase mid of february.

@Fabio1988 Fabio1988 changed the title rework showcase and add logs for second pokemon type rework showcase and add logs for other focuses Feb 21, 2024
@Fabio1988 Fabio1988 force-pushed the fix-showcases branch 2 times, most recently from 0ee7557 to 7d0f467 Compare September 3, 2024 14:52
@Fabio1988
Copy link
Collaborator Author

useful to refactor showcases... ponyta contained two focusses

METHOD_GET_CONTEST_DATA | 2105

GetContestDataProto {
    fort_id "5c73d33313a03606a6672c26a4e5ef6c.16"
}

GetContestDataOutProto {
    status Status.SUCCESS:1
    
    contest_incident {
        
        contests {
            contest_id "5c73d33313a03606a6672c26a4e5ef6c.16-CUSTOM-MAX-POKEMON_SIZE-1726322400001"
            focus_string_key "pokemon_name_0077"
            
            focus {
                
                pokemon {
                    pokedex_id HoloPokemonId.PONYTA:77
                }
            }
            
            metric {
                pokemon_metric ContestPokemonMetric.POKEMON_SIZE:1
                ranking_standard ContestRankingStandard.MAX:2
            }
            
            schedule {
                
                contest_cycle {
                    start_time_ms 1726322400001
                    end_time_ms 1726444800001
                    contest_occurrence ContestOccurrence.CUSTOM:8
                    custom_cycle_warmup_duration_ms 3600000
                    custom_cycle_cooldown_duration_ms 1
                }
            }
            
            focuses {
                
                pokemon {
                    pokedex_id HoloPokemonId.PONYTA:77
                    require_form_to_match true
                    
                    pokemon_display {}
                }
            }
            
            focuses {
                
                pokemon {
                    pokedex_id HoloPokemonId.PONYTA:77
                    require_form_to_match true
                    
                    pokemon_display {
                        form Form.PONYTA_NORMAL:1011
                    }
                }
            }
        }
    }
}
METHOD_GET_CONTEST_DATA | 2105

GetContestDataProto {
    fort_id "db3911e7e2fb4487bb5df412cda2a733.16"
}

GetContestDataOutProto {
    status Status.SUCCESS:1
    
    contest_incident {
        
        contests {
            contest_id "db3911e7e2fb4487bb5df412cda2a733.16-CUSTOM-MAX-POKEMON_SIZE-1726322400001"
            focus_string_key "pokemon_name_0077"
            
            focus {
                
                pokemon {
                    pokedex_id HoloPokemonId.PONYTA:77
                }
            }
            
            metric {
                pokemon_metric ContestPokemonMetric.POKEMON_SIZE:1
                ranking_standard ContestRankingStandard.MAX:2
            }
            
            schedule {
                
                contest_cycle {
                    start_time_ms 1726322400001
                    end_time_ms 1726444800001
                    contest_occurrence ContestOccurrence.CUSTOM:8
                    custom_cycle_warmup_duration_ms 3600000
                    custom_cycle_cooldown_duration_ms 1
                }
            }
            
            focuses {
                
                pokemon {
                    pokedex_id HoloPokemonId.PONYTA:77
                    require_form_to_match true
                    
                    pokemon_display {
                        form Form.PONYTA_GALARIAN:2336
                    }
                }
            }
        }
    }
}
METHOD_GET_CONTEST_DATA | 2105

GetContestDataProto {
    fort_id "cd266ebf35bc4b10be18075898001142.12"
}

GetContestDataOutProto {
    status Status.SUCCESS:1
    
    contest_incident {
        
        contests {
            contest_id "cd266ebf35bc4b10be18075898001142.12-CUSTOM-MAX-POKEMON_SIZE-1726322400001"
            focus_string_key "pokemon_name_0077"
            
            focus {
                
                pokemon {
                    pokedex_id HoloPokemonId.PONYTA:77
                }
            }
            
            metric {
                pokemon_metric ContestPokemonMetric.POKEMON_SIZE:1
                ranking_standard ContestRankingStandard.MAX:2
            }
            
            schedule {
                
                contest_cycle {
                    start_time_ms 1726322400001
                    end_time_ms 1726444800001
                    contest_occurrence ContestOccurrence.CUSTOM:8
                    custom_cycle_warmup_duration_ms 3600000
                    custom_cycle_cooldown_duration_ms 1
                }
            }
            
            focuses {
                
                pokemon {
                    pokedex_id HoloPokemonId.PONYTA:77
                    require_form_to_match true
                    
                    pokemon_display {}
                }
            }
            
            focuses {
                
                pokemon {
                    pokedex_id HoloPokemonId.PONYTA:77
                    require_form_to_match true
                    
                    pokemon_display {
                        form Form.PONYTA_NORMAL:1011
                    }
                }
            }
        }
    }
}


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant