Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: internal-backstage endpoints are disableable. #565

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

chriswk
Copy link
Contributor

@chriswk chriswk commented Oct 16, 2024

Sensitive endpoint (tokens, features, metricsbatch, metrics) can now all be turned off with separate flags

Co-authored-by: Simon Hornby [email protected]

Sensitive endpoint (tokens, features, metricsbatch, metrics) can now all
be turned off with separate flags
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chriswk chriswk force-pushed the task/disableInternalBackstageEndpoints branch from b785848 to 0fe940e Compare October 16, 2024 13:07
Copy link

github-actions bot commented Oct 16, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
cargo/prometheus-reqwest-remote-write 0.2.1 UnknownUnknown
cargo/prometheus-reqwest-remote-write >= 0.2.1, < 0.3.0 UnknownUnknown

Scanned Manifest Files

Cargo.lock
server/Cargo.toml
  • prometheus-reqwest-remote-write@>= 0.2.1, < 0.3.0
  • prometheus-reqwest-remote-write@>= 0.1.1, < 0.2.0

@chriswk chriswk enabled auto-merge (squash) October 16, 2024 13:12
@chriswk chriswk merged commit b1815f4 into main Oct 16, 2024
9 checks passed
@chriswk chriswk deleted the task/disableInternalBackstageEndpoints branch October 16, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants