fix: Handle archived/deleted projects #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, our cache refresh algorithm assumed that the response from upstream contained all projects we wanted to do updates to. Wayfair correctly reported this breaking their opportunity to archive/delete projects, since the cache would still contain deleted projects. This patch updates Edge to use the projects the token has access to decide whether or not to keep the elements in cache. New flow: 1. Fetch projects from token 2. Filter out all features belonging to these projects 3. Extend remaining list with update from response 4. Return extended list. fixes: #323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our cache refresh algorithm assumed that the response from upstream contained all projects we wanted to do updates to. Wayfair correctly reported this breaking their opportunity to archive/delete projects, since the cache would still contain deleted projects.
This patch updates Edge to use the projects the token has access to decide whether or not to keep the elements in cache.
New flow:
fixes: #323