feat: add hot reloading and an optional, simpler file format to offline mode #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswk
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some nice tooling for local development in offline mode. That's two things, firstly the user can now specify a reload interval, which will cause Edge to reload the offline file every X seconds. The second is a simpler format to specify the offline bootstrap in. That's a very, very simplified format, which Edge maps into a full ClientFeatures response matching the expected set properties. Together these allow the user to fiddle with toggles when in offline mode easily so that they can force their SDKs into the states that they want
Almost all of this code does not touch
edgemode, which is primarily what production environments use. It's also all opt in. So I think this is relatively safe to merge