Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hot reloading and an optional, simpler file format to offline mode #242

Merged
merged 5 commits into from
Sep 8, 2023

Conversation

sighphyre
Copy link
Member

@sighphyre sighphyre commented Sep 7, 2023

This adds some nice tooling for local development in offline mode. That's two things, firstly the user can now specify a reload interval, which will cause Edge to reload the offline file every X seconds. The second is a simpler format to specify the offline bootstrap in. That's a very, very simplified format, which Edge maps into a full ClientFeatures response matching the expected set properties. Together these allow the user to fiddle with toggles when in offline mode easily so that they can force their SDKs into the states that they want

Almost all of this code does not touch edge mode, which is primarily what production environments use. It's also all opt in. So I think this is relatively safe to merge

@sighphyre sighphyre marked this pull request as ready for review September 8, 2023 06:58
Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the added simple format here.

@sighphyre sighphyre merged commit 5100737 into main Sep 8, 2023
7 checks passed
@sighphyre sighphyre deleted the feat/offline-dev-ex branch September 8, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants