Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid blanket import from GHC.Conc #398

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

edsko
Copy link
Contributor

@edsko edsko commented Oct 28, 2023

Corresponding ticket for async itself at simonmar/async#153.

@Bodigrim
Copy link
Collaborator

@amesgen if you get a moment to fix WASM CI job, it would be most appreciated. (I assume it's just a hash change, but cannot verify AFK)

@Bodigrim
Copy link
Collaborator

@edsko could you please rebase?

Any particular motivation for this change? Why GHC.Conc only?

@edsko
Copy link
Contributor Author

edsko commented Oct 31, 2023

@Bodigrim Have rebased. As for motivation: GHC.Conc exports some stuff that Control.Concurrent.STM also exports, which leads to name clashes when using a version of stm that doesn't straight up re-export stuff from GHC.Conc but does something slightly different (such as specifically https://github.com/edsko/stm-debug).

@Bodigrim Bodigrim merged commit 410a9a4 into UnkindPartition:master Oct 31, 2023
13 checks passed
@Bodigrim
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants