Two IntMap-related improvements #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the only reason behind `IntMap ()` was the absense of `Data.IntMap.withoutKeys`, which was only added in `containers-0.5.8`.
At the moment we use `Data.IntMap` which is lazy in values, and we initialise values with thunks `testStatus <$> testActions`. This is outright silly: `testStatus` is just a selector for `TVar` field, forcing it to WHNF can do no harm. We also take an opportunity to replace `IntMap.fromList` with `IntMap.fromDistinctAscList`.
andreasabel
reviewed
Sep 24, 2023
andreasabel
reviewed
Sep 24, 2023
|
@andreasabel good catch. I can put CPP of course, but I have no reason to keep compatibility with GHC < 8.6 (where 8.6 is only because of GHCJS). How do you feel about dropping earlier versions? |
|
Thinking it over, I guess it is fine to go ahead with this PR as-is. |
martijnbastiaan
approved these changes
Sep 26, 2023
andreasabel
approved these changes
Sep 26, 2023
|
FWIW, looks good to me too! :) Thank you for the improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
launchTestTree: useIntMapstrict in valuesAt the moment we use
Data.IntMapwhich is lazy in values, and we initialise values with thunkstestStatus <$> testActions. This is outright silly:testStatusis just a selector forTVarfield, forcing it to WHNF can do no harm.We also take an opportunity to replace
IntMap.fromListwithIntMap.fromDistinctAscList.statusMapResult: useIntSetinstead ofIntMap ()It seems the only reason behind
IntMap ()was the absense ofData.IntMap.withoutKeys, which was only added incontainers-0.5.8.CC @martijnbastiaan for review