Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: UUM-71260 Removed redundant warning #2020

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

smnwttbr
Copy link
Collaborator

@smnwttbr smnwttbr commented Oct 1, 2024

Description

This PR removed a redundant warning when a JSON string cannot be parsed and a fallback JSON deserializer must be used.

https://jira.unity3d.com/browse/UUM-71260

Changes made

Removed a warning, added ProfileMarker for when fallback parser is used.

Testing

Manual testing

Risk

No risk.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@smnwttbr smnwttbr self-assigned this Oct 1, 2024
@smnwttbr smnwttbr marked this pull request as draft October 1, 2024 03:37
@smnwttbr smnwttbr marked this pull request as ready for review October 1, 2024 03:45
@smnwttbr smnwttbr requested a review from ekcoh October 1, 2024 07:46
@Pauliusd01
Copy link
Collaborator

Will check today

Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this.

@smnwttbr smnwttbr merged commit 24012a0 into develop Oct 11, 2024
77 checks passed
@smnwttbr smnwttbr deleted the uum-71260-remove-hid-parse-warning branch October 11, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants