Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #540

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Fixed #540

merged 1 commit into from
Jul 29, 2023

Conversation

Harshu467
Copy link
Contributor

Footer Icon bug || Issue Number 533

As mentioned in issue #533 , Icons are enhanced with UI as discuss in issue

Closes: #533

Describe the changes you've made

I have updated className for the design I mentioned in issue

Type of change

I made changes in className

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

I have run and checked UI to test it

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated

|
image
|
image
|

Code of Conduct

@vercel
Copy link

vercel bot commented Jul 28, 2023

@Harshu467 is attempting to deploy a commit to the Vibey Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

Thank you, @Harshu467, for creating this pull request and contributing to GitHub-ReadMe!
Our review team will thoroughly review the pull request and will reach out to you soon!
Please make sure you have marked all the completed tasks as done.
We appreciate your patience and contribution!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a pull request for vibey!

We appreciate your contribution and are excited to review your changes. If you have any questions or need additional information, please don't hesitate to let us know. We look forward to working with you to improve vibey. Thanks again for your support!

If you want to keep contributing to open source and want to do it with a supportive and inclusive community, consider joining UniKonf. We help and encourage each other to make regular contributions to open source projects. If you have any questions, do not hesitate to ask. We look forward to having you as part of our community!

@Harshu467
Copy link
Contributor Author

Please Check and merge PR and give labels of GSOC and level

@Deepu178 Deepu178 added gssoc23 This label aids in the tracking of issues for octabot used by GSSoC'23 for tracking. level1 Level describing the difficulty nature of the raised issue labels Jul 28, 2023
@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vibey ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 6:07pm

Copy link
Collaborator

@Deepu178 Deepu178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Harshu467 for the contribution

@Deepu178 Deepu178 merged commit 6e77fd9 into UniKonf:main Jul 29, 2023
6 checks passed
@Harshu467
Copy link
Contributor Author

Harshu467 commented Jul 29, 2023

Please Assign issue #515 as conversation has been locked , Please assign it so I can work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 This label aids in the tracking of issues for octabot used by GSSoC'23 for tracking. level1 Level describing the difficulty nature of the raised issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Footer Icons
2 participants