Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aria attributes to login and register forms #535

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Added aria attributes to login and register forms #535

merged 1 commit into from
Jul 28, 2023

Conversation

Avinash905
Copy link
Contributor

Related Issue

Closes: #476

Describe the changes you've made

Added aria attributes like aria-required, required, role, legend to fieldset headings in login and register forms which increases the accessibility of the forms.

Type of change

What sort of change have you made:

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.

Code of Conduct

@vercel
Copy link

vercel bot commented Jul 27, 2023

@Avinash905 is attempting to deploy a commit to the Vibey Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

Thank you, @Avinash905, for creating this pull request and contributing to GitHub-ReadMe!
Our review team will thoroughly review the pull request and will reach out to you soon!
Please make sure you have marked all the completed tasks as done.
We appreciate your patience and contribution!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a pull request for vibey!

We appreciate your contribution and are excited to review your changes. If you have any questions or need additional information, please don't hesitate to let us know. We look forward to working with you to improve vibey. Thanks again for your support!

If you want to keep contributing to open source and want to do it with a supportive and inclusive community, consider joining UniKonf. We help and encourage each other to make regular contributions to open source projects. If you have any questions, do not hesitate to ask. We look forward to having you as part of our community!

@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vibey ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 5:51am

Copy link
Collaborator

@Deepu178 Deepu178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Avinash905

@Deepu178 Deepu178 merged commit 76b8aba into UniKonf:main Jul 28, 2023
6 checks passed
@Avinash905
Copy link
Contributor Author

@Deepu178 Could you please add the labels?

@Deepu178 Deepu178 added gssoc23 This label aids in the tracking of issues for octabot used by GSSoC'23 for tracking. level1 Level describing the difficulty nature of the raised issue labels Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 This label aids in the tracking of issues for octabot used by GSSoC'23 for tracking. level1 Level describing the difficulty nature of the raised issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add ARIA attributes to login and signup forms
2 participants