Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Dark Mode Color Contrast Issue on Login and Signup Page #521

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

s2sharpit
Copy link
Contributor

Related Issue

  • Information about the related issue

Closes: #518

Describe the changes you've made

Type of change

What sort of change have you made:

  • Wrapped all the input in div and added dark:text-black for dark mode.
  • Changed the focus color to apply also when selected in auth.tsx to make the text visibility better.
  • removed darkMode: "class" to apply dark: classes like dark:text-black.
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
image image

Code of Conduct

Signed-off-by: Tushar Saini <[email protected]>
@vercel
Copy link

vercel bot commented Jul 26, 2023

@s2sharpit is attempting to deploy a commit to the Vibey Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

Thank you, @s2sharpit, for creating this pull request and contributing to GitHub-ReadMe!
Our review team will thoroughly review the pull request and will reach out to you soon!
Please make sure you have marked all the completed tasks as done.
We appreciate your patience and contribution!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a pull request for vibey!

We appreciate your contribution and are excited to review your changes. If you have any questions or need additional information, please don't hesitate to let us know. We look forward to working with you to improve vibey. Thanks again for your support!

If you want to keep contributing to open source and want to do it with a supportive and inclusive community, consider joining UniKonf. We help and encourage each other to make regular contributions to open source projects. If you have any questions, do not hesitate to ask. We look forward to having you as part of our community!

@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vibey ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 3:10pm

@Deepu178
Copy link
Collaborator

@s2sharpit it's failing in production. Can you check by building locally by running "pnpm run build"

@s2sharpit
Copy link
Contributor Author

s2sharpit commented Jul 26, 2023

@s2sharpit it's failing in production. Can you check by building locally by running "pnpm run build"

Hey @Deepu178, I found that there is a type error in file ./src/pages/dashboard/add_event.tsx.
The error is arises after merging of this pr #429 . Can I fix it?

Here is the screenshot of it:

image

image

@s2sharpit
Copy link
Contributor Author

Ohh, there is more problems in same file:
image

Signed-off-by: Tushar Saini <[email protected]>
@Deepu178
Copy link
Collaborator

@s2sharpit
@suzy-g38 has fixed the error and will push the changes soon. so yeah no need to work on already solved issue.

Copy link
Collaborator

@Deepu178 Deepu178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the contribution to the project and looking forward to see more contribution from your side. @s2sharpit
you have also solve type issue

@Deepu178 Deepu178 merged commit 448eb68 into UniKonf:main Jul 26, 2023
3 checks passed
@s2sharpit s2sharpit deleted the contrast-issue branch July 26, 2023 15:28
@s2sharpit
Copy link
Contributor Author

Hey @Deepu178,
I'm a GSSoC23 contributor, so would request you to add appropriate labels to this PR.

@s2sharpit
Copy link
Contributor Author

Hey @Deepu178, Please add appropriate labels to this PR.

@Deepu178 Deepu178 added gssoc23 This label aids in the tracking of issues for octabot used by GSSoC'23 for tracking. level2 Level describing the difficulty nature of the raised issue labels Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 This label aids in the tracking of issues for octabot used by GSSoC'23 for tracking. level2 Level describing the difficulty nature of the raised issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Dark Mode Color Contrast Issue on Login and Signup Page
2 participants