Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Google and GitHub icon #506

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

akshaysoni10
Copy link

Related Issue

  • Added Google and GitHub icon in SIgn in with Google and Sign in with GitHub.

Closes: #480

Describe the changes you've made

Added icon

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
original screenshot updated screenshot

Code of Conduct

@vercel
Copy link

vercel bot commented Jul 18, 2023

@akshaysoni10 is attempting to deploy a commit to the Vibey Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

Thank you, @akshaysoni10, for creating this pull request and contributing to GitHub-ReadMe!
Our review team will thoroughly review the pull request and will reach out to you soon!
Please make sure you have marked all the completed tasks as done.
We appreciate your patience and contribution!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a pull request for vibey!

We appreciate your contribution and are excited to review your changes. If you have any questions or need additional information, please don't hesitate to let us know. We look forward to working with you to improve vibey. Thanks again for your support!

If you want to keep contributing to open source and want to do it with a supportive and inclusive community, consider joining UniKonf. We help and encourage each other to make regular contributions to open source projects. If you have any questions, do not hesitate to ask. We look forward to having you as part of our community!

@money8203 money8203 requested a review from Deepu178 July 27, 2023 09:22
@suzy-g38
Copy link
Collaborator

@akshaysoni10 please resolve the conflict.

@akshaysoni10
Copy link
Author

@suzy-g38 conflict resolved

@suzy-g38
Copy link
Collaborator

@akshaysoni10 I will review this PR and will merge soon. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Google icon and Github icon in Sign in with Google and Sign in with GitHub button.
2 participants