Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected state feature #78 #86

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kamalshree
Copy link

Description

Implemented the Selected Places Screen Activity using MVP, with layout,Presenter Factory, drawables, String values, Id as requested,Also implemented the Toolbar.

Fixes # [78]

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance
  • User Interface

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)

screenshot_20180510-001657

@vvkvivekl
Copy link
Collaborator

@kamalshree thank you, we will check this in some time.. 😊

@Rondaul
Copy link
Collaborator

Rondaul commented May 11, 2018

Please resolved your merge conflicts first

@kamalshree
Copy link
Author

@Rondaul Resolved the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants