Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #51 - Place Details Screen #58

Conversation

kamalshree
Copy link

Description

Implemented the PlaceDetails Screen as per the mockup.

Fixes # [51]

Type of Change:

Delete irrelevant options.

  • Created the slider Image on the page.
  • Implemented the sub Toolbar
  • Also implemented the Text Slider.

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

placedetails

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.
N/A

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • Tested locally both Landscape and Portrait mode and it works fine.

@harikautilya
Copy link
Contributor

@kamalshree Can you implement the Same in MVP and update the PR

@geekanamika
Copy link
Collaborator

@kamalshree Adding to the kautilya's statement, Please make sure that there're no merge conflicts.

@harikautilya
Copy link
Contributor

@kamalshree since it's high time and there is a duplicate PR as well ...we will abort this PR

Duplicate : #61

@harikautilya harikautilya added the duplicate This issue or pull request already exists label May 5, 2018
@kamalshree
Copy link
Author

Indeed , Thanks

@vvkvivekl
Copy link
Collaborator

duplicate

@vvkvivekl vvkvivekl closed this May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants