-
Notifications
You must be signed in to change notification settings - Fork 4
PM Takeoff/Landing Implementation #25
base: main
Are you sure you want to change the base?
Conversation
…into PM/New_Arch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions about the SM changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cant read
PathManager/Src/PM_States.cpp
Outdated
void CommsWithSystemManager::execute(PathManager* pathMgr) | ||
{ | ||
//GetSMIncomingData(); | ||
/* | ||
|
||
*/ | ||
|
||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something missing here? Since the thread that calls PM handles the PM side of the message queues is this necessary?
/* TODO: All of this | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:surprised pikachu:
SystemManager/Src/SM.cpp
Outdated
path_manager->setSmStruct(*pm_instructions); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use the sm_pm_queue status to check if there is new data from SM and only update this if there is new data? I worry that PM takes multiple execute calls to get through a full control loop.
AM::AttitudeManagerInput to_am_data = path_manager->getAmStruct(); | ||
void* msg_pointer = &to_am_data; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this AmStruct get updated after each execute call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Description
PR for Takeoff/Landing with PM using speed targets. Includes message queue implementation with SM and AM.
Testing
Work in Progress
Documentation
https://uwarg-docs.atlassian.net/wiki/spaces/ZP/pages/2022146309/VTOL+Takeoff+and+Landing
https://uwarg-docs.atlassian.net/wiki/spaces/ZP/pages/2117664813/PM+Re+Architecture+For+MVP
Merge Checklist: