Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox fix #61

Merged
merged 12 commits into from
Jul 16, 2024
Merged

Firefox fix #61

merged 12 commits into from
Jul 16, 2024

Conversation

TyHil
Copy link
Member

@TyHil TyHil commented Apr 11, 2024

Firefox requires requesting host permissions instead of automatically granting them.

This PR opens a prompt to grant permissions on install and every time skedge is opened without correct permissions.

@TyHil TyHil assigned nl32 and TyHil Apr 11, 2024
@nl32 nl32 marked this pull request as ready for review April 15, 2024 21:58
@nl32
Copy link
Contributor

nl32 commented Apr 15, 2024

If the user tries to open the extension and doesn't have host permissions, it will now open the popup and request them.
Also added styling so the popup uses the right font and button uses blue-dark

src/background/index.ts Outdated Show resolved Hide resolved
src/tabs/permissions.tsx Outdated Show resolved Hide resolved
src/popup.tsx Outdated Show resolved Hide resolved
@TyHil TyHil requested a review from demonlexe July 10, 2024 12:58
@TyHil TyHil merged commit 9fd5ea7 into develop Jul 16, 2024
1 check passed
@TyHil TyHil deleted the firefox-fix branch July 16, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants