Update main with recent PRs #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TyHil
commented
Feb 22, 2024
TyHil
commented
- Convert to async/await instead of .then() logics, organizing awaits (SKEDGE-14)
- Lint and format scripts
- Replace API request using Trends backend
- Load profs independently
- Fetch cache
- Add functionality for Disabled tab
- Fix top tags
…urses which do not exist on Nebula API
…organizing awaits
…tiple listings for a professor on RMP, use the one with the most ratings.
Update develop to match main due to minor release changed
…n for the RMP fetches to avoid 504 error. #comment address requests from Adam Szumski #comment add new interfaces for the Professor Rating object
…itial fetches of professors from RMP
…nction, instead of grouping fetches. (This way seems shorter and safer)
…eir routing works.
Sk.edge Maintenance Updates / Bug Fixes
…sor-bug SKEDGE-16 #comment Patch for single professor with middle name for courses which do not exist on Nebula API
…ing-inconsistency-issue SKEDGE-14 #comment convert to async/await instead of .then() logics, organizing awaits
* Lint and format scripts, pre-commit hook, configure eslint * Working linting * Working and run prettier * Working and run eslint * Readd lint-staged prettier filter * lint on commit * Fix .prettierignore * Update package-lock * Don't limit lint-staged prettier filter * Lint fixes
Lint and format
Replace API request using Trends backend
Load profs independently
Fetch cache
Feature: Add functionality for Disabled tab
Fix/top tags
iamwood
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.