Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/top tags #52

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Fix/top tags #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5211a76
Reverse sort
TyHil Jan 3, 2024
4887a51
Merge branch 'replace-api-request' into fix/top-tags
TyHil Jan 27, 2024
21b170e
Merge branch 'replace-api-request' into fix/top-tags
TyHil Jan 27, 2024
6d5f8fd
Merge branch 'develop' into fix/top-tags
TyHil Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/data/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export async function buildProfessorProfile(
? rmp?.wouldTakeAgainPercent
: undefined,
rmpTags: rmp?.teacherRatingTags
.sort((a, b) => a.tagCount - b.tagCount)
.sort((a, b) => b.tagCount - a.tagCount)
.map((tag) => tag.tagName),
gradeDistribution: [
{
Expand Down
2 changes: 1 addition & 1 deletion src/pages/ProfessorProfile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const ProfessorProfile = () => {
{' '}
{/* RMP Tag area */}
{professorData.rmpTags
?.slice(0, 4)
?.slice(0, 5)
.map((item: string, index: number) => (
<RmpTag key={index} text={item.toUpperCase()} />
))}
Expand Down
Loading