Replace API request using Trends backend #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 2, 2024
|
@iamwood Do you think this is worth breaking up into smaller PR's. I think it's probably fine, but is a large change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #48, #37, #28
Makes call to nebula API via
trends.utdnebula.com/apiinstead ofapi.utdnebula.comto conceal API key.Removes API key from config. We should consider removing the API key from the git history with something like
git filter-branch --tree-filter "sed -i 's/EM~eW}G<}4qx41fp{H=I]OZ5MF6T:1x{<GF:~v</API_KEY/' src\data\config.ts" --alland a force pushReformats API calls to all go at once instead of one at a time, should speed up Skedge.
A few small things added along the way:
Adds titles to define RMP, DIFF, and WTA as Overall Quality, Level of Difficulty, and Would take again.
Adds a link to Trends in professor profiles, moves the link to RMP alongside the Trends one at the bottom of the page.